-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sleep adapter behavior #1309
Conversation
- sleep adapter was not working when the `until` parameter was specified on as a run request parameter
], | ||
"tasks": [ | ||
{"type": "sleep"}, | ||
{"type": "noop"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix this in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the failed go data race CI, the changes look good to me.
Looks pre-existing. I can't reproduce when rerunning. |
Fixes the sleep adapter when specifying its
until
parameter in a run request.